global: variable names are CamelCase

            ___  _         ___     __
           / _ )(_)__ _   / _/__ _/ /_
          / _  / / _ `/  / _/ _ `/ __/
         /____/_/\_, /  /_/ \_,_/\__/
 _       __     /___/       _             __
| |     / /___ __________  (_)___  ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / /  / / / / / / / / /_/ /_/
|__/|__/\__,_/_/  /_/ /_/_/_/ /_/\__, (_)
                                /____/

RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:

[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

That looks ok. Now we use a script:

{ :local interface "en1";
  / interface print where name=$interface; }

And the result...

[admin@MikroTik] > { :local interface "en1";
{...   / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

... still looks ok.
We make a little modification to the script:

{ :local name "en1";
  / interface print where name=$name; }

And the result:

[admin@MikroTik] > { :local name "en1";
{...   / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598
 1   S en2                                 ether            1500  1598
 2   S en3                                 ether            1500  1598
 3   S en4                                 ether            1500  1598
 4   S en5                                 ether            1500  1598
 5  R  br-local                            bridge           1500  1598

Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).

And another modification:

{ :local type "en1";
  / interface print where name=$type; }

And the result:

[admin@MikroTik] > { :local type "en1";
{...   / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU

Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.

The answer from MikroTik support (in Ticket#2019010222000454):

> This is how scripting works in RouterOS and we will not fix it.

To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...

*fingers crossed*

1 files changed, 10 insertions, 10 deletions

diff --git a/dhcp-lease-comment.local b/dhcp-lease-comment.local
index 82cc9a9..98c11cc 100644
--- a/dhcp-lease-comment.local
+++ b/dhcp-lease-comment.local
@@ -6,16 +6,16 @@
 #
 # !! Do not edit this file, it is generated from template!
 
-:foreach lease in=[ / ip dhcp-server lease find where dynamic=yes ] do={
-  :local macaddress [ / ip dhcp-server lease get $lease mac-address ];
-  :local oldcomment [ / ip dhcp-server lease get $lease comment ];
-  :local newcomment;
-  :local accesslst [ :pick [ / interface wireless access-list find where mac-address=$macaddress ] 0 ];
-  :if ( [ :len $accesslst ] > 0 ) do={
-    :set newcomment [ / interface wireless access-list get $accesslst comment ];
+:foreach Lease in=[ / ip dhcp-server lease find where dynamic=yes ] do={
+  :local MacAddress [ / ip dhcp-server lease get $Lease mac-address ];
+  :local OldComment [ / ip dhcp-server lease get $Lease comment ];
+  :local NewComment;
+  :local AccessList [ :pick [ / interface wireless access-list find where mac-address=$MacAddress ] 0 ];
+  :if ([ :len $AccessList ] > 0) do={
+    :set NewComment [ / interface wireless access-list get $AccessList comment ];
   }
-  :if ([ :len $newcomment ] != 0 && $oldcomment != $newcomment) do={
-    :log info ("Updating comment for DHCP lease " . $macaddress . ": " . $newcomment);
-    / ip dhcp-server lease set comment=$newcomment $lease;
+  :if ([ :len $NewComment ] != 0 && $OldComment != $NewComment) do={
+    :log info ("Updating comment for DHCP lease " . $MacAddress . ": " . $NewComment);
+    / ip dhcp-server lease set comment=$NewComment $Lease;
   }
 }