| Age | Commit message (Expand) | Author | Files | Lines |
|---|
| 2019-11-25 | collect-wireless-mac: lease without address should be impossible...•••... we need the check for empty hostname, though.
|  Christian Hesse | 1 | -5/+2 |
| 2019-11-25 | collect-wireless-mac: move code into condition | Christian Hesse | 1 | -6/+6 |
| 2019-04-03 | always write warnings and errors to log | Christian Hesse | 1 | -1/+2 |
| 2019-02-21 | collect-wireless-mac: use $ScriptLock | Christian Hesse | 1 | -0/+3 |
| 2019-01-15 | collect-wireless-mac: simplify array access | Christian Hesse | 1 | -1/+1 |
| 2019-01-04 | global: variable names are CamelCase••• ___ _ ___ __
/ _ )(_)__ _ / _/__ _/ /_
/ _ / / _ `/ / _/ _ `/ __/
/____/_/\_, / /_/ \_,_/\__/
_ __ /___/ _ __
| | / /___ __________ (_)___ ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / / / / / / / / / / /_/ /_/
|__/|__/\__,_/_/ /_/ /_/_/_/ /_/\__, (_)
/____/
RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:
[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
That looks ok. Now we use a script:
{ :local interface "en1";
/ interface print where name=$interface; }
And the result...
[admin@MikroTik] > { :local interface "en1";
{... / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
... still looks ok.
We make a little modification to the script:
{ :local name "en1";
/ interface print where name=$name; }
And the result:
[admin@MikroTik] > { :local name "en1";
{... / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
1 S en2 ether 1500 1598
2 S en3 ether 1500 1598
3 S en4 ether 1500 1598
4 S en5 ether 1500 1598
5 R br-local bridge 1500 1598
Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).
And another modification:
{ :local type "en1";
/ interface print where name=$type; }
And the result:
[admin@MikroTik] > { :local type "en1";
{... / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.
The answer from MikroTik support (in Ticket#2019010222000454):
> This is how scripting works in RouterOS and we will not fix it.
To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...
*fingers crossed*
| Christian Hesse | 1 | -38/+38 |
| 2019-01-02 | update copyright for 2019 | Christian Hesse | 1 | -1/+1 |
| 2018-12-28 | global-functions: properly define global functions | Christian Hesse | 1 | -1/+0 |
| 2018-12-27 | global-functions: add $GetMacVendor | Christian Hesse | 1 | -8/+2 |
| 2018-12-20 | global-functions: make $CertificateAvailable work on CommonName•••This should prevent endless certificate switching for Let's Encrypt
cross-signed intermediate certificates.
| Christian Hesse | 1 | -1/+1 |
| 2018-12-14 | collect-wireless-mac: send the mac's vendor part only | Christian Hesse | 1 | -1/+1 |
| 2018-12-14 | collect-wireless-mac: get and record the vendor | Christian Hesse | 1 | -2/+12 |
| 2018-11-28 | global-functions: add identity tag in $SendNotification•••... and send subject in telegram message.
| Christian Hesse | 1 | -1/+1 |
| 2018-10-10 | global: remove unused variables | Christian Hesse | 1 | -2/+0 |
| 2018-10-09 | collect-wireless-mac: use function for notification | Christian Hesse | 1 | -3/+4 |
| 2018-09-27 | start scripts with a magic token / shebang | Christian Hesse | 1 | -1/+1 |
| 2018-08-24 | add empty comment at first line...•••... for better formatting in export.
| Christian Hesse | 1 | -0/+1 |
| 2018-07-10 | update template system | Christian Hesse | 1 | -8/+2 |
| 2018-07-09 | introduce templates for scripts depending on capsman or local wireless | Christian Hesse | 1 | -0/+62 |
Christian Hesse