Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2019-02-13 | global-functions: introduce and use $CleanFilePath | Christian Hesse | 1 | -4/+21 | |
2019-02-13 | global-functions: remove file on failed download | Christian Hesse | 1 | -3/+9 | |
2019-02-11 | global-functions: add missing colon | Christian Hesse | 1 | -1/+1 | |
2019-02-08 | global-functions: prevent infinite loop in $CharacterReplace | Christian Hesse | 1 | -0/+4 | |
2019-02-08 | global-functions: add $CharacterReplace | Christian Hesse | 1 | -0/+15 | |
2019-01-04 | global: variable names are CamelCase | Christian Hesse | 1 | -58/+58 | |
___ _ ___ __ / _ )(_)__ _ / _/__ _/ /_ / _ / / _ `/ / _/ _ `/ __/ /____/_/\_, / /_/ \_,_/\__/ _ __ /___/ _ __ | | / /___ __________ (_)___ ____ _/ / | | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ / | |/ |/ / /_/ / / / / / / / / / / /_/ /_/ |__/|__/\__,_/_/ /_/ /_/_/_/ /_/\__, (_) /____/ RouterOS has some odd behavior when it comes to variable names. Let's have a look at the interfaces: [admin@MikroTik] > / interface print where name=en1 Flags: D - dynamic, X - disabled, R - running, S - slave # NAME TYPE ACTUAL-MTU L2MTU 0 RS en1 ether 1500 1598 That looks ok. Now we use a script: { :local interface "en1"; / interface print where name=$interface; } And the result... [admin@MikroTik] > { :local interface "en1"; {... / interface print where name=$interface; } Flags: D - dynamic, X - disabled, R - running, S - slave # NAME TYPE ACTUAL-MTU L2MTU 0 RS en1 ether 1500 1598 ... still looks ok. We make a little modification to the script: { :local name "en1"; / interface print where name=$name; } And the result: [admin@MikroTik] > { :local name "en1"; {... / interface print where name=$name; } Flags: D - dynamic, X - disabled, R - running, S - slave # NAME TYPE ACTUAL-MTU L2MTU 0 RS en1 ether 1500 1598 1 S en2 ether 1500 1598 2 S en3 ether 1500 1598 3 S en4 ether 1500 1598 4 S en5 ether 1500 1598 5 R br-local bridge 1500 1598 Ups! The filter has no effect! That happens whenever the variable name ($name) matches the property name (name=). And another modification: { :local type "en1"; / interface print where name=$type; } And the result: [admin@MikroTik] > { :local type "en1"; {... / interface print where name=$type; } Flags: D - dynamic, X - disabled, R - running, S - slave # NAME TYPE ACTUAL-MTU L2MTU Ups! Nothing? Even if the variable name ($type) matches whatever property name (type=) things go wrong. The answer from MikroTik support (in Ticket#2019010222000454): > This is how scripting works in RouterOS and we will not fix it. To get around this we use variable names in CamelCase. Let's hope Mikrotik never ever introduces property names in CamelCase... *fingers crossed* | |||||
2019-01-03 | global-{config,functions}: move variables, make independent | Christian Hesse | 1 | -1/+6 | |
2019-01-03 | script-updates: add configuration versioning | Christian Hesse | 1 | -0/+3 | |
2019-01-02 | update copyright for 2019 | Christian Hesse | 1 | -1/+1 | |
2018-12-28 | global-functions: properly define global functions | Christian Hesse | 1 | -0/+2 | |
2018-12-28 | global-functions: update comment in $SendNotification | Christian Hesse | 1 | -1/+1 | |
2018-12-28 | global-functions: add $DownloadPackage | Christian Hesse | 1 | -0/+25 | |
... and make script 'capsman-download-packages' use it. | |||||
2018-12-27 | global-functions: add $GetMacVendor | Christian Hesse | 1 | -0/+15 | |
2018-12-20 | global-functions: make $CertificateAvailable work on CommonName | Christian Hesse | 1 | -7/+8 | |
This should prevent endless certificate switching for Let's Encrypt cross-signed intermediate certificates. | |||||
2018-12-12 | remove extra dollar sign | Christian Hesse | 1 | -2/+2 | |
2018-11-28 | global-functions: add identity tag in $SendNotification | Christian Hesse | 1 | -2/+4 | |
... and send subject in telegram message. | |||||
2018-11-09 | global-functions: use 'print count-only' | Christian Hesse | 1 | -1/+1 | |
2018-11-09 | global-functions: add function to read user input | Christian Hesse | 1 | -0/+5 | |
2018-10-16 | global-functions: import certificates if required | Christian Hesse | 1 | -3/+24 | |
Signed-off-by: Christian Hesse <mail@eworm.de> | |||||
2018-10-15 | global-functions: fix missing colon | Christian Hesse | 1 | -2/+2 | |
2018-10-12 | global-functions: make sure parameters are strings | Christian Hesse | 1 | -6/+7 | |
2018-10-10 | daily-psk: move function GeneratePSK from global-functions | Christian Hesse | 1 | -42/+0 | |
2018-10-09 | global-functions: add UrlEncode and use in SendNotification | Christian Hesse | 1 | -1/+25 | |
2018-10-09 | global-functions: add function to notify via e-mail and telegram | Christian Hesse | 1 | -0/+35 | |
2018-10-09 | global-functions: move daily psk secrets to global-config | Christian Hesse | 1 | -15/+4 | |
2018-10-09 | make GeneratePSK a global function | Christian Hesse | 1 | -0/+52 | |
2018-10-09 | add global-functions | Christian Hesse | 1 | -0/+6 | |