From 49650d8b14541f96784948e88504629fd24d53ce Mon Sep 17 00:00:00 2001
From: Christian Hesse <mail@eworm.de>
Date: Mon, 4 Mar 2024 13:48:01 +0100
Subject: lease-script: move code into function

---
 lease-script.rsc | 71 +++++++++++++++++++++++++++++++-------------------------
 1 file changed, 40 insertions(+), 31 deletions(-)

diff --git a/lease-script.rsc b/lease-script.rsc
index aae74f8..d9c7177 100644
--- a/lease-script.rsc
+++ b/lease-script.rsc
@@ -8,45 +8,54 @@
 # run scripts on DHCP lease
 # https://git.eworm.de/cgit/routeros-scripts/about/doc/lease-script.md
 
-:local 0 [ :jobname ];
 :global GlobalFunctionsReady;
 :while ($GlobalFunctionsReady != true) do={ :delay 500ms; }
 
-:global Grep;
-:global IfThenElse;
-:global LogPrintExit2;
-:global ParseKeyValueStore;
-:global ScriptLock;
-
-:if ([ :typeof $leaseActIP ] = "nothing" || \
-     [ :typeof $leaseActMAC ] = "nothing" || \
-     [ :typeof $leaseServerName ] = "nothing" || \
-     [ :typeof $leaseBound ] = "nothing") do={
-  $LogPrintExit2 error $0 ("This script is supposed to run from ip dhcp-server.") true;
-}
+:local Main do={
+  :local ScriptName      [ :tostr $1 ];
+  :local leaseActIP      [ :tostr $2 ];
+  :local leaseActMAC     [ :tostr $2 ];
+  :local leaseServerName [ :tostr $2 ];
+  :local leaseBound      [ :tostr $2 ];
+
+  :global Grep;
+  :global IfThenElse;
+  :global LogPrintExit2;
+  :global ParseKeyValueStore;
+  :global ScriptLock;
+
+  :if ([ :typeof $leaseActIP ] = "nothing" || \
+       [ :typeof $leaseActMAC ] = "nothing" || \
+       [ :typeof $leaseServerName ] = "nothing" || \
+       [ :typeof $leaseBound ] = "nothing") do={
+    $LogPrintExit2 error $ScriptName ("This script is supposed to run from ip dhcp-server.") true;
+  }
 
-$LogPrintExit2 debug $0 ("DHCP Server " . $leaseServerName . " " . [ $IfThenElse ($leaseBound = 0) \
-  "de" "" ] . "assigned lease " . $leaseActIP . " to " . $leaseActMAC) false;
+  $LogPrintExit2 debug $ScriptName ("DHCP Server " . $leaseServerName . " " . [ $IfThenElse ($leaseBound = 0) \
+    "de" "" ] . "assigned lease " . $leaseActIP . " to " . $leaseActMAC) false;
 
-$ScriptLock $0 false 10;
+  $ScriptLock $ScriptName false 10;
 
-:if ([ :len [ /system/script/job/find where script=$0 ] ] > 1) do={
-  $LogPrintExit2 debug $0 ("More invocations are waiting, exiting early.") true;
-}
+  :if ([ :len [ /system/script/job/find where script=$ScriptName ] ] > 1) do={
+    $LogPrintExit2 debug $ScriptName ("More invocations are waiting, exiting early.") true;
+  }
 
-:local RunOrder ({});
-:foreach Script in=[ /system/script/find where source~("\n# provides: lease-script\\b") ] do={
-  :local ScriptVal [ /system/script/get $Script ];
-  :local Store [ $ParseKeyValueStore [ $Grep ($ScriptVal->"source") ("\23 provides: lease-script, ") ] ];
+  :local RunOrder ({});
+  :foreach Script in=[ /system/script/find where source~("\n# provides: lease-script\\b") ] do={
+    :local ScriptVal [ /system/script/get $Script ];
+    :local Store [ $ParseKeyValueStore [ $Grep ($ScriptVal->"source") ("\23 provides: lease-script, ") ] ];
 
-  :set ($RunOrder->($Store->"order" . "-" . $ScriptVal->"name")) ($ScriptVal->"name");
-}
+    :set ($RunOrder->($Store->"order" . "-" . $ScriptVal->"name")) ($ScriptVal->"name");
+  }
 
-:foreach Order,Script in=$RunOrder do={
-  :do {
-    $LogPrintExit2 debug $0 ("Running script with order " . $Order . ": " . $Script) false;
-    /system/script/run $Script;
-  } on-error={
-    $LogPrintExit2 warning $0 ("Running script '" . $Script . "' failed!") false;
+  :foreach Order,Script in=$RunOrder do={
+    :do {
+      $LogPrintExit2 debug $ScriptName ("Running script with order " . $Order . ": " . $Script) false;
+      /system/script/run $Script;
+    } on-error={
+      $LogPrintExit2 warning $ScriptName ("Running script '" . $Script . "' failed!") false;
+    }
   }
 }
+
+$Main [ :jobname ] $leaseActIP $leaseActMAC $leaseServerName $leaseBound;
-- 
cgit v1.2.3-70-g09d2