From 9aed03693c918aaff5462e9ed2300c05a787d2c4 Mon Sep 17 00:00:00 2001
From: Christian Hesse <mail@eworm.de>
Date: Thu, 5 Mar 2020 12:42:21 +0100
Subject: netwatch-notify: fix handling of array

Looks like handling of more-dimensional arrays is a bit tricky in
RouterOS... Without this *all* values with the same key name are
updated, independent of intermediate name.
---
 netwatch-notify | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/netwatch-notify b/netwatch-notify
index 04e3d30..dfa62e8 100644
--- a/netwatch-notify
+++ b/netwatch-notify
@@ -17,23 +17,25 @@
   :local HostVal [ / tool netwatch get $Host ];
   :local HostName ([ $ParseKeyValueStore ($HostVal->"comment") ]->"hostname");
 
-  :if ([ :typeof ($NetwatchNotify->$HostName) ] = "nothing") do={
-    :set ($NetwatchNotify->$HostName) { "count"=0; "notified"=false };
+  :local Metric { "count"=0; "notified"=false };
+  :if ([ :typeof ($NetwatchNotify->$HostName) ] = "array") do={
+    :set $Metric ($NetwatchNotify->$HostName);
   }
 
   :if ($HostVal->"status" = "up") do={
-    :set ($NetwatchNotify->$HostName->"count") 0;
-    :if ($NetwatchNotify->$HostName->"notified" = true) do={
+    :set ($Metric->"count") 0;
+    :if ($Metric->"notified" = true) do={
       $SendNotification ("Netwatch Notify: " . $HostName . " up") \
         ("Host " . $HostName . " (" . $HostVal->"host" . ") is up since " . $HostVal->"since" . ".");
     }
-    :set ($NetwatchNotify->$HostName->"notified") false;
+    :set ($Metric->"notified") false;
   } else={
-    :set ($NetwatchNotify->$HostName->"count") ($NetwatchNotify->$HostName->"count" + 1);
-    :if ($NetwatchNotify->$HostName->"count" >= 5 && $NetwatchNotify->$HostName->"notified" != true) do={
+    :set ($Metric->"count") ($Metric->"count" + 1);
+    :if ($Metric->"count" >= 5 && $Metric->"notified" != true) do={
       $SendNotification ("Netwatch Notify: " . $HostName . " down") \
         ("Host " . $HostName . " (" . $HostVal->"host" . ") is down since " . $HostVal->"since" . ".");
-      :set ($NetwatchNotify->$HostName->"notified") true;
+      :set ($Metric->"notified") true;
     }
   }
+  :set ($NetwatchNotify->$HostName) { "count"=($Metric->"count"); "notified"=($Metric->"notified") };
 }
-- 
cgit v1.2.3-70-g09d2